[FFmpeg-devel] [PATCH]set lavf ident string globally
Sun Feb 14 19:19:43 CET 2010
On Sun, Feb 14, 2010 at 04:04:18PM +0100, Anton Khirnov wrote:
> On Sun, Feb 14, 2010 at 11:29:17AM +0100, Michael Niedermayer wrote:
> > grep '_build\W' libavcodec/*.c
> yeah that's decoders. my patch only affects muxing and no demuxer does this.
Thats because most muxers dont store their name and version.
There are many mpeg-ps/ts and avi files that are broken in various ways,
it surely wouldnt hurt if we could check for the muxer instead of guessing
which value should be interpreted how.
(just see ffplays timestamp analysis code, had the buggy mpeg-ps muxers
stored their name we could do it exactly instead of guessing)
> > does your patch change the regression test checksums?
> no since regtests set bitexact flag. i've tested this manually though
> and avi muxer produces identical files both with and without the patch.
> mp3 muxer doesn't because with the patch TSSE frame is correctly written
> only once.
and the others? (fliping the bitexactflag runing regtests and updating
all checksums should be trivial)
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel