[FFmpeg-devel] [PATCH]HE-AACv1 try 3 (all missing functionality added)

Michael Niedermayer michaelni
Mon Feb 15 02:36:46 CET 2010


On Sun, Feb 14, 2010 at 08:26:59PM -0500, Alex Converse wrote:
> On Sat, Feb 13, 2010 at 11:31 AM, Vitor Sessak <vitor1001 at gmail.com> wrote:
> > Alex Converse wrote:
[...]
> >> +static void sbr_extension(SpectralBandReplication *sbr, GetBitContext
> >> *gb,
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ?int bs_extension_id, int *num_bits_left)
> >> +{
> >> +/* TODO - implement ps_data for parametric stereo parsing
> >> + ? ?switch (bs_extension_id) {
> >> + ? ?case EXTENSION_ID_PS:
> >> + ? ? ? ?num_bits_left -= ps_data(sbr, gb);
> >> + ? ? ? ?break;
> >> + ? ?default:
> >> +*/
> >> + ? ? ? ?skip_bits(gb, *num_bits_left); // bs_fill_bits
> >> + ? ? ? ?*num_bits_left = 0;
> >> +/*
> >> + ? ? ? ?break;
> >> + ? ?}
> >> +*/
> >> +}
> >
> > Isn't it missing a call to av_log_missing_feature()?
> 
> People complained constantly about av_log_missing_feature() spamming
> the console on finding SBR.

we might need a av_log_missing_feature_once( ..., uint8_t *was_printed)


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100215/41560019/attachment.pgp>



More information about the ffmpeg-devel mailing list