[FFmpeg-devel] [PATCH] Fix inclusion in pixdesc.h of the non-public header intreadwrite.h

Måns Rullgård mans
Mon Feb 15 14:00:42 CET 2010

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sun, Feb 14, 2010 at 11:39:35PM +0100, Stefano Sabatini wrote:
>> Hi all,
>> intreadwrite.h is not public so we should not include it in a public
>> header, this also fixes a bunch of warnings during compilation.
>> Also read_line() and write_line() are just meant for
>> testing/debugging/pedagogical purposes, so the fact that they're not
>> defined inline shouldn't be relevant.
> no, read/write_line() are an essential and important part of pixdescs
> They where intended as fallback for very rarely used convertions in swscale
> having a specific optimized converter for each pixel format is overkill
> especially on CONFIG_SMALL targets

Having them inline in the public header doesn't exactly fit with that
description, so I think the patch is fine.  No functionality is being

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list