[FFmpeg-devel] [PATCH] Fix inclusion in pixdesc.h of the non-public header intreadwrite.h

Michael Niedermayer michaelni
Mon Feb 15 19:54:36 CET 2010


On Mon, Feb 15, 2010 at 06:37:19PM +0000, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Mon, Feb 15, 2010 at 01:00:42PM +0000, M?ns Rullg?rd wrote:
> >> Michael Niedermayer <michaelni at gmx.at> writes:
> >> 
> >> > On Sun, Feb 14, 2010 at 11:39:35PM +0100, Stefano Sabatini wrote:
> >> >> Hi all,
> >> >> 
> >> >> intreadwrite.h is not public so we should not include it in a public
> >> >> header, this also fixes a bunch of warnings during compilation.
> >> >> 
> >> >> Also read_line() and write_line() are just meant for
> >> >> testing/debugging/pedagogical purposes, so the fact that they're not
> >> >> defined inline shouldn't be relevant.
> >> >
> >> > no, read/write_line() are an essential and important part of pixdescs
> >> > They where intended as fallback for very rarely used convertions in swscale
> >> > having a specific optimized converter for each pixel format is overkill
> >> > especially on CONFIG_SMALL targets
> >> 
> >> Having them inline in the public header doesn't exactly fit with that
> >> description, so I think the patch is fine.  No functionality is being
> >> removed.
> >
> > well, if its important to you then iam ok with moving them to the c file
> >
> > but i still do want intreadwrite public ...
> 
> That's a different debate.
> 
> > it is usefull and used
> 
> That's impossible.

in mplayer trunk
grep 'AV_R[BL][0-9]' *.{c,h} libmp*/*.{c,h} |wc
    108     564    7751

not to mention libavcodec & avformat are also different libs than libavutil

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100215/e90cb673/attachment.pgp>



More information about the ffmpeg-devel mailing list