[FFmpeg-devel] [RFC] Hack to disable implicit rules
Tue Feb 16 20:53:34 CET 2010
On Tue, Feb 16, 2010 at 07:45:13PM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > On Tue, Feb 16, 2010 at 09:43:34AM +0000, M?ns Rullg?rd wrote:
> >> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> >> > Hello,
> >> > since I've only recently seen them causing issues (mostly due to MinGW and
> >> > Cygwin make being broken most of the time) and found a way that seems
> >> > to disable them (although maybe more as a side-effect), I'd like to propose
> >> > this patch.
> >> > What are your opinions?
> >> > Index: common.mak
> >> > ===================================================================
> >> > --- common.mak (revision 21840)
> >> > +++ common.mak (working copy)
> >> > @@ -4,6 +4,10 @@
> >> >
> >> > all: # make "all" default target
> >> >
> >> > +# disable suffix rules, we do not use them and like this we avoid (most?)
> >> > +# implicit rules which might cause slowdowns or bugs
> >> > +.SUFFIXES:
> >> > +
> >> Does this fix an actual problem?
> > Not for FFmpeg, no.
> Then it serves no purpose. Code (in the broader sense) without a
> purpose does not belong in FFmpeg.
Just thought I remembered someone saying they'd prefer to get rid of the
implicit rules stuff, maybe also because they slow down compilation on Windows
(I don't know if it really makes a significant difference).
More information about the ffmpeg-devel