[FFmpeg-devel] [PATCH] Fix inclusion in pixdesc.h of the non-public header intreadwrite.h
Tue Feb 16 21:17:01 CET 2010
On date Tuesday 2010-02-16 09:35:28 +0000, M?ns Rullg?rd encoded:
> Michael Niedermayer <michaelni at gmx.at> writes:
> > On Mon, Feb 15, 2010 at 01:00:42PM +0000, M?ns Rullg?rd wrote:
> >> Michael Niedermayer <michaelni at gmx.at> writes:
> >> > On Sun, Feb 14, 2010 at 11:39:35PM +0100, Stefano Sabatini wrote:
> >> >> Hi all,
> >> >>
> >> >> intreadwrite.h is not public so we should not include it in a public
> >> >> header, this also fixes a bunch of warnings during compilation.
> >> >>
> >> >> Also read_line() and write_line() are just meant for
> >> >> testing/debugging/pedagogical purposes, so the fact that they're not
> >> >> defined inline shouldn't be relevant.
> >> >
> >> > no, read/write_line() are an essential and important part of pixdescs
> >> > They where intended as fallback for very rarely used convertions in swscale
> >> > having a specific optimized converter for each pixel format is overkill
> >> > especially on CONFIG_SMALL targets
> >> Having them inline in the public header doesn't exactly fit with that
> >> description, so I think the patch is fine. No functionality is being
> >> removed.
> > well, if its important to you then iam ok with moving them to the c file
> Regardless of the fate of intreadwrite.h, can we please just apply
> this patch? It fixes an immediate error, and seems to be the right
> thing to do either way.
FFmpeg = Foolish and Forgiving MultiPurpose Easy Gangster
More information about the ffmpeg-devel