[FFmpeg-devel] [PATCH] Bink Video decoder for FFmpeg 0.6
Wed Feb 17 18:56:54 CET 2010
On Wed, Feb 17, 2010 at 06:07:37AM -0800, Jason Garrett-Glaser wrote:
> >> + ? ? ? ?if (!plane || !c->swap_planes)
> >> + ? ? ? ? ? ?plane_idx = plane;
> >> + ? ? ? ?else
> >> + ? ? ? ? ? ?plane_idx = plane ^ 3;
> >> I'd ternary this.
> > Why?
> Cleaner, shorter.
> > Mainly because quant table index must be read after all DCT coefficients
> > are decoded (sounds like bad design to me).
> Sounds like you need a dequant DSP function then. This would benefit
> greatly from asm.
> You could also track the last nnz and only dequant up to it.
I've managed to merge dequant with coefficient decoding instead.
> Dark Shikari
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 79777 bytes
Desc: not available
More information about the ffmpeg-devel