[FFmpeg-devel] [PATCH] RTSP muxer, round 3

[Ronald S. Bultje]

Hi Martin,

On Wed, Feb 17, 2010 at 1:59 PM, Martin Storsj? <martin at martin.st> wrote:
> On Wed, 17 Feb 2010, Ronald S. Bultje wrote:
>> > Sure - I've got ideas on how to split this file into rtsp.c, rtspdec.c,
>> > rtspenc.c relatively cleanly. It's easier to do the split once the muxer
>> > code is in place, though, so is it ok for you to first apply this, then do
>> > the split?
>>
>> Well, so you can already start putting muxer-specific code in
>> rtspenc.c without rtspdec.c being there. Or at least, that's my logic.
>
> Yeah, that's true - the really muxer specific parts can go there without
> trouble. The setup_output_streams that's called from
> rtsp_read_header/rtsp_connect needs to be in the main module initially,
> though.
>
> I thought about making that one specified through a function pointer as a
> parameter to rtsp_connect instead, so the rtsp_setup_in/output_streams
> could be moved to the respective muxer/demuxer files instead, when I'm
> splitting them. Or should I take the function pointer approach now before
> applying it at all?

No that's OK, I don't mind that one function if the others move and it
makes the process faster.

Ronald