[FFmpeg-devel] [PATCH] Add AMR-NB decoder, next try

Vitor Sessak vitor1001
Thu Feb 18 21:02:53 CET 2010


Colin McQuillan wrote:
> On 31 January 2010 20:59, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> Hi,
>>
>> On Jan 31, 2010, at 3:45 PM, Martin Storsj? <martin at martin.st> wrote:
>>> When testing this in valgrind, I noticed that decode_fixed_sparse only
>>> initializes the no_repeat_mask field for some modes, but not for all,
>>> triggering warnings for using uninitialized data in ff_set_fixed_vector
>>> and ff_clear_fixed_vector.
>> That's expected, I just added that and Colin probably didn't update the SoC
>> tree yet. We'll fix that before it's committed.
> 
> Is it ok to just initialize the struct to 0? I.e:

Fine IMHO.

-Vitor



More information about the ffmpeg-devel mailing list