[FFmpeg-devel] [PATCH] RTSP muxer, round 5
Ronald S. Bultje
Mon Feb 22 17:24:14 CET 2010
On Mon, Feb 22, 2010 at 11:06 AM, Martin Storsj? <martin at martin.st> wrote:
> On Mon, 22 Feb 2010, Ronald S. Bultje wrote:
>> Patch 8 imo needs doxy comments for the functions since they are now
>> non-static. Could you add these?
> Yeah, sure. rtsp_read_reply already has a doxy comment in rtsp.c, I could
> move that one along to .h when making it non-static, and add something
> similar for the other ones. Do you prefer to have this as separate patches
> (first make non-static and move existing doxy, then add new doxy for the
> other ones)?
For the ones that have doxy, move it while making them non-static
(same patch). For the others, add doxy as you make them non-static.
Static functions don't specifically need doxy imo, non-static
functions should always have doxy, so it makes sense to add doxy as
you make them non-static in the same patch.
More information about the ffmpeg-devel