[FFmpeg-devel] [PATCH/RFC] Constify src in av_fifo_generic_write()

Tomas Härdin tomas.hardin
Tue Feb 23 10:50:03 CET 2010

Good morning

This is a rather simple patch that merely makes av_fifo_generic_write()
take const void *src instead of just void *src. It causes no warnings
and regression tests pass.

The reason is simple: guarantee the user that the function does not
modify src.

One small issue though: this necessitated changing func to int(*)(const
void*,void*,int), which is OK for all code within FFmpeg. However, this
seems to count as a minor API change since g++ (and gcc I presume) won't
allow implicitly casting int(*)(void*,void*,int) to int(*)(const
void*,void*,int). I presume that part requires a bit of discussion,
which is why I marked this thread "RFC".

Patch attached.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fifo_const.patch
Type: text/x-patch
Size: 1288 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100223/bb2384fe/attachment.bin>

More information about the ffmpeg-devel mailing list