[FFmpeg-devel] [RFC][PATCH] Add support for 12-bit color mode.
Sat Feb 27 18:51:19 CET 2010
On Sat, Feb 27, 2010 at 12:58:35PM +0100, Janusz Krzysztofik wrote:
> Saturday 27 February 2010 10:36:32 Stefano Sabatini wrote:
> > I belieive the patch should be split for easing review.
> OK, I'll split it into a series for next iteration.
> > First step
> > could be to hook the definitions of the pixel format ids, the pixel
> > format desciption and the info in libavcodec/imgconvert.c.
> Any more suggetions on what can be split, and what should be kept together?
> I'm probably not that familiar with the code to choose the way to go other
> than splitting by subdirectory or source file.
the unscaled "special" converters should be split off from the patches
adding support in the generic (slower) code path.
Also all asm optimizations should be split off the pure C code so we can
first get the C code through review and then the asm can be reviewed by the
respective maintainers who know the specific asm.
ahh and, your patch is big, optimizing obscure combinations might not
be worth, the generic codepath should be able to handle them.
That said i would mind less to have hundreads of unscaled converters
for each case if they could be disabled at compile time
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel