[FFmpeg-devel] [RFC][PATCH] Add support for 12-bit color mode.

Michael Niedermayer michaelni
Sun Feb 28 02:56:18 CET 2010

On Sun, Feb 28, 2010 at 12:05:37AM +0100, Janusz Krzysztofik wrote:
> Saturday 27 February 2010 18:51:19 Michael Niedermayer wrote:
> > On Sat, Feb 27, 2010 at 12:58:35PM +0100, Janusz Krzysztofik wrote:
> > >
> > > Any more suggetions on what can be split, and what should be kept
> > > together? I'm probably not that familiar with the code to choose the way
> > > to go other than splitting by subdirectory or source file.
> >
> > the unscaled "special" converters should be split off from the patches
> > adding support in the generic (slower) code path.
> Michael,
> OK, I'll try to discern these cases.
> > Also all asm optimizations should be split off the pure C code so we can
> > first get the C code through review and then the asm can be reviewed by the
> > respective maintainers who know the specific asm.
> That seems easier :).
> Besides, would you rather like me to submit the resulting patches in a few 
> separate series?

seperate threads are prefered if that was what you meant ...

> > ahh and, your patch is big, optimizing obscure combinations might not
> > be worth, the generic codepath should be able to handle them.
> If I create a separate patch for each one, couldn't less important just be 
> dropped up to your decision? 

yes we could drop less important ones

> > That said i would mind less to have hundreads of unscaled converters
> > for each case if they could be disabled at compile time
> Doesn't it sound like a distinct task that should be covered by a separate 
> patch, not related to rgb12 support?

yes of course

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100228/3d691284/attachment.pgp>

More information about the ffmpeg-devel mailing list