[FFmpeg-devel] [PATCH] Implement avfilter_add_colorspaces()

Stefano Sabatini stefano.sabatini-lala
Sat Jan 2 19:46:02 CET 2010


On date Saturday 2010-01-02 18:44:44 +0100, Michael Niedermayer encoded:
> On Sat, Jan 02, 2010 at 12:42:55AM +0100, Stefano Sabatini wrote:
> > On date Friday 2010-01-01 22:03:56 +0100, Michael Niedermayer encoded:
> > > On Fri, Jan 01, 2010 at 01:32:32PM +0100, Stefano Sabatini wrote:
> > [...]
> > > > Index: libavfilter-soc/ffmpeg/libavfilter/avfilter.h
> > > > ===================================================================
> > > > --- libavfilter-soc.orig/ffmpeg/libavfilter/avfilter.h	2009-12-30 01:24:53.000000000 +0100
> > > > +++ libavfilter-soc/ffmpeg/libavfilter/avfilter.h	2010-01-01 13:10:31.000000000 +0100
> > > > @@ -192,6 +192,14 @@
> > > >  AVFilterFormats *avfilter_make_format_list(const enum PixelFormat *pix_fmts);
> > > >  
> > > >  /**
> > > > + * Adds pix_fmt to the list of formats in formats.
> > > > + *
> > > > + * @return 0 in case of success or AVERROR(ENOMEM) if the formats list
> > > > + * cannot be re-allocated.
> > > > + */
> > > 
> > > I think ive said it in the past already, plase keep API/ABI in a way that is
> > > not so locked down we need to bump the major version every day.
> > > >= 0 success
> > > <0 error code for example ENOMEM
> > 
> > Updated.
> [...]
> > +int avfilter_add_colorspace(AVFilterFormats *formats, enum PixelFormat pix_fmt)
> > +{
> > +    formats->formats = av_realloc(formats->formats,
> > +                                  sizeof(formats->formats) * ++formats->format_count);
> > +    if (!formats->formats)
> > +        return AVERROR(ENOMEM);
> 
> memleak

New try.
-- 
FFmpeg = Faboulous Fiendish Murdering Philosofic Enhanced Guide
-------------- next part --------------
A non-text attachment was scrubbed...
Name: implement-add-colorspace.patch
Type: text/x-diff
Size: 1584 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100102/148b08b0/attachment.patch>



More information about the ffmpeg-devel mailing list