[FFmpeg-devel] [PATCH] ffprobe integration

Diego Biurrun diego
Sat Jan 2 22:17:01 CET 2010


On Sat, Jan 02, 2010 at 10:02:00PM +0100, Stefano Sabatini wrote:
> 
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ ffmpeg/ffprobe.c	2010-01-02 22:01:41.000000000 +0100
> @@ -0,0 +1,363 @@
> +/*
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFprobe; if not, write to the Free Software

FFmpeg

> +static char *value_string(char *buf, int buf_size, double val, UnitId unit, int flags)

long line

> +        usecs = (int)(round((val - floor(val)) * 1000000));
> +        secs = (int)val;
> +        mins = secs / 60;
> +        secs %= 60;
> +        hours = mins / 60;
> +        mins %= 60;

This could be more readable aligned, same in other places..

> +static char *time_value_string (char *buf, int buf_size, int64_t val,
> +                                AVRational *time_base, int value_string_flags)

stray space before (

> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ ffmpeg/doc/ffprobe-doc.texi	2010-01-02 22:00:22.000000000 +0100
> @@ -0,0 +1,73 @@
> +
> +It may be used to print information about the format of a multimedia
> +file or stream, of each single stream and of each single packet or
> +frame contained in it.

This is still confusing.

What else can it be used for?  Clean dishes?  Just say that it prints
information, not that it can be used to print information, which
implies it has other uses.

I also don't understand what the second half of the sentence after the
comma is trying to say.  What do single stream/packet refer to?

> +FFprobe may be used both as a standalone application or in combination
> +with a textual filter, which may be used to perform more sophisticated

s/be used to//

Diego



More information about the ffmpeg-devel mailing list