[FFmpeg-devel] [PATCH/RFC] Prefer getaddrinfo over gethostbyname

Ronald S. Bultje rsbultje
Mon Jan 4 04:33:36 CET 2010


On Sun, Jan 3, 2010 at 6:11 PM, Martin Storsj? <martin at martin.st> wrote:

Now, as for patches.
0001 (check for getaddrinfo) - can be applied if Diego / Mans are OK with it
0002 (getaddrinfo instead of gethostbyname) - ok with me
0003 (configure) - not for me (Diego / Mans)
0004 (struct sockaddr_storage etc.) - ok with me, same as 0001
0005 (addrinfo) - as said before, use ff_ prefix and add define to
header, then OK with me
0006 (mark as deprecated) - can be applied
0007 (tcp) -

+    if (fd < 0) {
+        freeaddrinfo(ai);
         return AVERROR(EIO);
+    }

shouldn't that be goto fail; and retry next address? OK otherwise.

0008 (udp) - looks ok but somebody else with more knowledge of udp
might want to look at it (e.g. Luca), I'm not familiar with it.


More information about the ffmpeg-devel mailing list