[FFmpeg-devel] -std=c99 breaks mingw32 build with libfaac

[Diego Biurrun]

On Thu, Jan 07, 2010 at 10:34:54AM +0800, Zuxy Meng wrote:
> 2010/1/7 Ramiro Polla <ramiro.polla at gmail.com>:
> > On Wed, Jan 6, 2010 at 11:57 PM, Zuxy Meng <zuxy.meng at gmail.com> wrote:
> >> 2010/1/6 Ramiro Polla <ramiro.polla at gmail.com>:
> >>> It has already been fixed in faac 1.28. Zuxy, what versions of faac
> >>> and mingw are you using?
> >>
> >> I'm using 1.26. So those guys have changed the calling convention; no
> >> problem then:-)
> >
> > IIRC they changed WIN32 to _WIN32 and kept stdcall.
> 
> #if defined(_WIN32) && !defined(__MINGW32__)
> # ifndef FAACAPI
> #  define FAACAPI __stdcall
> # endif
> #else
> # ifndef FAACAPI
> #  define FAACAPI
> # endif
> #endif

Why should we go out of our way to work around other people's bugs?
Bugs that they have fixed already..
Just use the fixed version and be done with it...

Diego