[FFmpeg-devel] [PATCH] ALS: Solve Issue 1657

Thilo Borgmann thilo.borgmann
Thu Jan 7 23:24:00 CET 2010


Am 07.01.10 22:19, schrieb Michael Niedermayer:
> On Thu, Jan 07, 2010 at 01:15:20PM +0100, Thilo Borgmann wrote:
>> Am 07.01.10 09:33, schrieb Reimar D?ffinger:
>>> On Thu, Jan 07, 2010 at 01:19:57AM +0100, Thilo Borgmann wrote:
>>>>>>>            y += MUL64(lpc_cof[sb], raw_samples[sb]);
>>>>>>>
>>>>>>>        *raw_samples++ -= y >> 20;
>>>>>>>    }
>>>>>
>>>>> checking the end via raw_samples < end should be faster
>>>>> (1 variable less, 1 ++ less)
>>>>> also if this is on x86_64 try to make sb long instead of int this
>>>>> too might help
>>>>
>>>> Yes and yes:
>>>
>>> x86_reg would also work for mingw64
>>
>> Patch attached using faster "raw_samples < end"-loop.
>>
>> What still might be improved, is to type variable "sb" for different
>> architectures but my question about how to do this in ffmpeg still
>> remains open. Though, this might be a more general request for the
>> decoder and therefore worth another patch/thread...
>>
>> -Thilo
> 
>>  alsdec.c |   25 +++++++++++++++++++------
>>  1 file changed, 19 insertions(+), 6 deletions(-)
>> b6552e939b9152ef05bedf648876cd1a0930add0  als_issue1657_better.rev1.patch
> 
> ok

Thanks, applied.

-Thilo



More information about the ffmpeg-devel mailing list