[FFmpeg-devel] [PATCH] Get rid of unused PREFETCHW and prefer MMX2 over 3DNow!

[Michael Niedermayer]

On Fri, Jan 08, 2010 at 11:37:17AM +0800, Zuxy Meng wrote:
> Hi,
> 
> We never used PREFETCHW in libswscale, and MMX2's prefetchnta is
> preferrable than 3DNow!'s prefetch due to the former's non temporal
> hint.
> 
> -- 
> Zuxy
> Beauty is truth,
> While truth is beauty.
> PGP KeyID: E8555ED6

>  rgb2rgb_template.c |   12 ++++--------
>  swscale_template.c |   10 +++-------
>  2 files changed, 7 insertions(+), 15 deletions(-)
> 596c1966a2582e14b7eec570fd57db77da8d8386  prefetch.diff
> Index: libswscale/swscale_template.c
> ===================================================================
> --- libswscale/swscale_template.c	(?? 30234)
> +++ libswscale/swscale_template.c	(??????)
> @@ -25,17 +25,13 @@
>  #undef MOVNTQ
>  #undef PAVGB
>  #undef PREFETCH
> -#undef PREFETCHW
>  
> -#if COMPILE_TEMPLATE_AMD3DNOW
> -#define PREFETCH  "prefetch"
> -#define PREFETCHW "prefetchw"
> -#elif COMPILE_TEMPLATE_MMX2
> +#if COMPILE_TEMPLATE_MMX2
>  #define PREFETCH "prefetchnta"
> -#define PREFETCHW "prefetcht0"
> +#elif COMPILE_TEMPLATE_AMD3DNOW
> +#define PREFETCH  "prefetch"
>  #else
>  #define PREFETCH  " # nop"
> -#define PREFETCHW " # nop"
>  #endif

you are mixing 2 unrelated changes in one patch (which makes it unreadable)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100108/059df741/attachment.pgp>