[FFmpeg-devel] [PATCH] H264 DXVA2 implementation

Reimar Döffinger Reimar.Doeffinger
Sun Jan 10 21:16:03 CET 2010

On Sun, Jan 10, 2010 at 08:48:46PM +0100, Laurent Aimar wrote:
> Hi,
> On Sun, Jan 10, 2010, Reimar D?ffinger wrote:
> > Which of course means the requirements for FFmpeg change from "requires a C99 compatible compiler" to
> > "requires a compiler compatible to some bastardized mix of C99 and whatever Microsoft calls C", not to
> > mention that you'd probably also need -mms-bitfields.
> > And with all that compiler checks to make sure we don't mess up too much if any of these are not available.
>  I can also send a patch that only use the field bPicEntry and then remove the
> nameless struct/union in the header (it won't be complete anymore but still
> usable).

_I_ think that would be a good solution, adding the appropriate compiler flags
would be possible, too, but it certainly will be more than one line in configure
(at least: Makefile so it is only used for that file, configure: only check
if the flag is available, don't add it to cflags, fail or disable dxva if it
is not supported).
You could of course make this removal depend on a define being set if you want
to keep compatibility.
Of course one point to consider is whether possibly a stripped-down version
of the header should be committed to FFmpeg if the "default" Microsoft one will
not work for it (at least not without adding extra CFLAGS).

More information about the ffmpeg-devel mailing list