[FFmpeg-devel] [PATCH] fix compilation in cygwin
Mon Jan 11 15:34:42 CET 2010
On Sun, Jan 10, 2010 at 09:55:50PM -0500, Vitor Sessak wrote:
> M?ns Rullg?rd wrote:
>> Vitor Sessak <vitor1001 at gmail.com> writes:
>>> +#if !HAVE_LOG2F
>>> +static av_always_inline av_const float log2f(float x)
>>> + return log(x) * 1.44269504088896340736;
>>> +#endif /* HAVE_LOG2F */
>> Calling log2() should be better. Most of the bad libs have a full set
>> of double-precision functions. It's the single-precision ones, which
>> were added in C99 that are often missing.
> Fine, even thought NetBSD lacks it (thats why we have a configure check for
> it, so no problem there).
>>> +#if !HAVE_EXP2F
>>> +static av_always_inline av_const float exp2f(float x)
>>> + return exp(x) * 0.693147180559945;
>>> +#endif /* HAVE_EXP2F */
>> Same again. exp2() should be preferred.
> Let's hope that at least exp2() is supported...
> configure | 4 ++++
> libavutil/internal.h | 14 ++++++++++++++
> 2 files changed, 18 insertions(+)
> f25bb41b563db2bd35239ca070cb257b2967566f fix_mingw3.diff
parts i maintain are ok
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel