[FFmpeg-devel] [PATCH] mkvdec: Fix crash with invalid real audio tracks (issue1656)
Tue Jan 12 00:05:06 CET 2010
On Sun, Jan 10, 2010 at 07:37:51PM -0500, David Conrad wrote:
> On Jan 10, 2010, at 12:56 PM, Aurelien Jacobs wrote:
> > On Tue, Jan 05, 2010 at 12:56:01AM -0500, David Conrad wrote:
> >> Hi,
> >> This simply doesn't descramble real audio if the parameters are
> >> obviously invalid. The audio won't work of course since needed
> >> info is missing, but it won't crash.
> > Patch OK.
> > I would be interested by a real-world sample triggering this issue
> > if you have any.
> Applied, and it's just files created by our muxer since supporting
> real audio means figuring out how to correctly write undocumented
> Real headers.
Real headers are at least partly documented
(see rmdec.c:rm_read_audio_stream_info() or in mkvtoolnix
So at least correctly writting the documented fields would be an improvement.
More information about the ffmpeg-devel