[FFmpeg-devel] [PATCH] Print some error in case of avfilter_graph_config_formats() failure

[Stefano Sabatini]

On date Sunday 2010-01-10 23:20:19 +0100, Michael Niedermayer encoded:
> On Sun, Jan 10, 2010 at 03:26:37PM +0100, Stefano Sabatini wrote:
> > On date Sunday 2010-01-10 03:25:36 +0100, Michael Niedermayer encoded:
> > > On Sun, Jan 10, 2010 at 02:08:24AM +0100, Stefano Sabatini wrote:
> > > > Hi,
> > > > 
> > > > currently:
> > > > $ ffplay -vfilters "format=pal8" in.avi
> > > > [...]
> > > > [format @ 0x9ec1f70]auto-inserting filter 'scale'
> > > > 
> > > > with all the patches applied:
> > > > $ ffplay -vfilters "format=pal8" in.avi
> > > > [...]
> > > > [format @ 0x9ec1f70]auto-inserting filter 'auto-inserted scaler 0'
> > > > Impossible to convert between the formats supported by the filter 'src' and the filter 'auto-inserted scaler 0'
> > > > 
> > > > Regards.
> > > > -- 
> > > > FFmpeg = Furious & Fostering Mortal Programmable Extreme Gymnast
> > > 
> > > all ok
> > 
> > Applied 1 and 3.
> > 
> > As for the second, after some thought I saw that it wasn't correct,
> > revised patch attached for increasing verbosity:
> > 
> > stefano at geppetto ~/s/l/ffmpeg> ffplay -vfilters "format=pal8" in.avi
> > [...]
> > [format @ 0xa4ddf70]auto-inserting filter 'auto-inserted scaler 0' between the filter 'src' and the filter 'Parsed filter 0'
> > Impossible to convert between the formats supported by the filter 'auto-inserted scaler 0' and the filter 'Parsed filter 0'
> > 
> > stefano at geppetto ~/s/l/ffmpeg> ffplay -vfilters "format=rgb4" in.avi
> > [...]
> > [format @ 0x8f73f70]auto-inserting filter 'auto-inserted scaler 0' between the filter 'src' and the filter 'Parsed filter 0'
> > [ffplay_output @ 0x8fabb90]auto-inserting filter 'auto-inserted scaler 1' between the filter 'Parsed filter 0' and the filter 'out'
> > Impossible to convert between the formats supported by the filter 'Parsed filter 0' and the filter 'auto-inserted scaler 1'
> > 
> > This is more correct and more informative.
> 
> fine

Applied.

> independant of that, filters need better names, "formats=rgb4" would be a
> better name form example, and adding a "2" if there is more than one ...

Regards.
-- 
FFmpeg = Foolish and Faithful Moronic Problematic Experimenting God