[FFmpeg-devel] [PATCH] fix stream copy

Michael Niedermayer michaelni
Wed Jan 13 16:56:04 CET 2010


On Wed, Jan 13, 2010 at 05:09:08PM +0200, Maksym Veremeyenko wrote:
[...]
>  ffmpeg.c |    7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 73833a815f1c3f858f7c5dd852279e600873fc32  ffmpeg.c-do_not_override_codec_time_base.patch
> Index: ffmpeg.c
> ===================================================================
> --- ffmpeg.c	(revision 21185)
> +++ ffmpeg.c	(working copy)
> @@ -1865,11 +1865,8 @@
>              codec->bit_rate = icodec->bit_rate;
>              codec->extradata= icodec->extradata;
>              codec->extradata_size= icodec->extradata_size;
> -            if(av_q2d(icodec->time_base)*icodec->ticks_per_frame > av_q2d(ist->st->time_base) && av_q2d(ist->st->time_base) < 1.0/1000){
> -                codec->time_base = icodec->time_base;
> -                codec->time_base.num *= icodec->ticks_per_frame;
> -            }else
> -                codec->time_base = ist->st->time_base;
> +            codec->time_base = icodec->time_base;
> +            codec->time_base.num *= icodec->ticks_per_frame;
>              switch(codec->codec_type) {

first you are reindenting code in a functional patch
second, you remove code at random without any explanation.
Noone is interrested if a random change fixes your single specific file
If you want this code removed you must explain why the original reason
why it was added no longer applies
Iam of course not in favor of every 6 month fliping a piece of code between
2 alternatives as it fixes A and break B then fixes B and breaks A


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100113/221f016f/attachment.pgp>



More information about the ffmpeg-devel mailing list