[FFmpeg-devel] [PATCH] Fix function parameters for rgb48 to YV12 functions.
Thu Jan 14 14:45:01 CET 2010
2010/1/14 M?ns Rullg?rd <mans at mansr.com>:
> Michael Niedermayer <michaelni at gmx.at> writes:
>> On Thu, Jan 14, 2010 at 04:25:01AM -0200, Ramiro Polla wrote:
>>> On Mon, Jan 11, 2010 at 12:51 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>>> > On Mon, Jan 11, 2010 at 05:21:19AM -0200, Ramiro Polla wrote:
>>> >> ?swscale.c | ? ?6 +++---
>>> >> ?1 file changed, 3 insertions(+), 3 deletions(-)
>>> >> 104e7c17caec26638ce07bb04dc15eaa0d9133fb ?0003-int-long-for-width-parameter-in-rgb48-to-YV12-fun.patch
>>> >> From da0f8f381054f23a32251981354ec56fb1232a56 Mon Sep 17 00:00:00 2001
>>> >> From: Ramiro Polla <ramiro.polla at gmail.com>
>>> >> Date: Mon, 11 Jan 2010 05:04:09 -0200
>>> >> Subject: [PATCH] int -> long for width parameter in rgb48 to YV12 functions.
>>> > dont we have a proper type for that?
>>> You mean x86_reg? That wouldn't be nice in a function declaration.
>>> What I have in mind now is changing them all to int, and cast to
>>> x86_reg (or use local x86_reg variables) only inside x86 or mmx
>>> ifdefs. What do you think about this approach?
>> whats the problem with x86_reg in a declaration?
> Using x86_reg in non-x86-specific code is ugly. ?In fact, it shouldn't
> even compile.
typedef int64_t x86_reg;
typedef int32_t x86_reg;
typedef int x86_reg;
So it does compile for now, but I'd like to remove that #else as well.
What do you think about that array_index type michael mentioned?
More information about the ffmpeg-devel