[FFmpeg-devel] [PATCH] fix stream copy

Michael Niedermayer michaelni
Thu Jan 14 16:33:24 CET 2010


On Thu, Jan 14, 2010 at 12:15:13PM +0200, Maksym Veremeyenko wrote:
> Michael Niedermayer ???????(??):
> [...]
>> first you are reindenting code in a functional patch
>> second, you remove code at random without any explanation.
>> Noone is interrested if a random change fixes your single specific file
>> If you want this code removed you must explain why the original reason
>> why it was added no longer applies
>> Iam of course not in favor of every 6 month fliping a piece of code 
>> between
>> 2 alternatives as it fixes A and break B then fixes B and breaks A
>
> it remove code parts introduced in two commits:
>
> ------------------------------------------------------------------------
> r6920 | michael | 2006-11-06 23:54:23 +0200 (Mon, 06 Nov 2006) | 2 lines
>
> 2nd try for -vcodec copy timebase selection last one choose 1fps due to 
> broken opendivx stream in avi (avi had the correct 15
>
> ------------------------------------------------------------------------
>
> and
>
> ------------------------------------------------------------------------
> r6847 | michael | 2006-10-31 02:39:02 +0200 (Tue, 31 Oct 2006) | 3 lines
>
> better timebase selection heuristic for video stream copy
> fixes -ss -t -vcodec copy
>
> ------------------------------------------------------------------------
>
> that is one fix for /broken opendivx stream/ and second is /heuristic/ - 
> that why i decide to remove them...

so it breaks opendivx and some files we dont know anymore
(and breakage here is fatal not just -t / -ss failure)


[...]
> May be you have a idea or some hints for me?

I dont think this code is related to your bug, the sync_opts stuff
in your other patch looks more related

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100114/9d5434c4/attachment.pgp>



More information about the ffmpeg-devel mailing list