[FFmpeg-devel] [PATCH] Make avfilter_default_start_frame() request a buffer with the same size of the output link
Fri Jan 15 00:39:53 CET 2010
On date Thursday 2010-01-14 01:23:54 +0100, Stefano Sabatini encoded:
> On date Thursday 2010-01-14 00:57:17 +0100, Stefano Sabatini encoded:
> > Hi, this fixes the rotate filter crash in soc, which was broken in
> > r20272.
> > By default avfilter_default_start_frame() requests a frame buffer
> > which is of the same size of the input link, which in this particular
> > case is *different* than the size of the output frame buffer.
> > We didn't noticed this as all the currently implemented filters with
> > an output size different from the input size were re-defined, so the
> > default callback was not called.
> Sorry for the miserable explanation I really should go to bed
> now. Anyway it was:
> "We didn't noticed this as all the currently implemented filters with
> an output size different from the input size, explicitely define a
> start_frame callback (e.g. pad, transpose, scale), so the default
> callback is not called."
I'll apply it tomorrow if there are not comments, as I think it's
quite straightforward and we have a crash depending on this.
FFmpeg = Fundamentalist Funny Martial Peaceless Ermetic God
More information about the ffmpeg-devel