[FFmpeg-devel] [PATCH] H264 DXVA2 implementation

[Laurent Aimar]

Hi,

On Fri, Jan 15, 2010, elupus wrote:
> On Thu, 14 Jan 2010 20:44:38 +0100, Laurent Aimar wrote:
> > On Thu, Jan 14, 2010, elupus wrote:
> >> [11 quoted lines suppressed]
> >  Thanks for the information.
> >  Just to be sure:
> >  - LPDIRECTXVIDEODECODER, LPDIRECTXVIDEOACCELERATIONSERVICE, LPDIRECTXVIDEODECODERSERVICE,
> >    LPDIRECT3DDEVICEMANAGER9 are not defined ?
> 
> Right.
> 
> >  - Can IDirectXVideoDecoder *, IDirectXVideoAccelerationService * ... be directly used
> >  or I need to use struct IDirectXVideoDecoder * ... ?
> 
> I think the C version used for ffmpeg does allow you to skip the struct (it
> compiled fine for me)
 Thanks

> Another thing i just noted:
> const DXVA2_ConfigPictureDecode *cfg;
> 
> Remove the const. Just makes things messier to setup.
 FFmpeg must not modify this structure, so the const is needed IMO.
In VLC, it does not make any problem to setup:
 dxva_ctx->cfg = &vlc_ctx->cfg;

Regards,

-- 
fenrir