[FFmpeg-devel] [PATCH] [3/3] SIPR 16k decoder
Sat Jan 16 04:55:04 CET 2010
Vitor Sessak wrote:
> On Thu, Jan 14, 2010 at 6:54 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> On Wed, Jan 13, 2010 at 11:15 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
>>> And now the decoder code.
>> +static void lsf2lsp(const float *lsf, double *lsp)
>> + int i;
>> + for (i = 0; i < LP_FILTER_ORDER_16k; i++)
>> + lsp[i] = cosf(lsf[i]);
>> So, in light of all recent discussion on types for whatnot, let's settle this.
>> What type should LSFs, LSPs and LPCs be? I mean, all decoders do this.
>> We can easily share it as long as we agree on this silly little thing.
> The rule I use is: always use floats, unless when you need to call
> ff_acelp_lspd2lpc(), which takes doubles as arguments (and also to
> avoiding converting buffers to double or back).
>> Rest of the patch OK. :-). Now I finally understand how to use AMRFixed.
All committed. The only hunk that was not really reviewed was trivial
and maintained by me.
More information about the ffmpeg-devel