[FFmpeg-devel] [PATCH] Enable proper IPv6 functions on windows
Sat Jan 16 15:48:16 CET 2010
On Sat, 16 Jan 2010, Reimar D?ffinger wrote:
> On Sat, Jan 16, 2010 at 03:58:50PM +0200, Martin Storsj? wrote:
> > win-ipv6-load.patch adds a winsock specific GetModuleHandle +
> > GetProcAddress at the beginning of each of the wrapper fallbacks, making
> > it backwards compatible while giving the new functionality on newer
> > versions. If this path is chosen, commit 21227 can (should?) be reverted.
> > Reimar, does this one look sensible to you?
> I see no obvious problems with it.
> > 0001... first changes the current addition of the _WIN32_WINNT
> > define to only be added if target-os = mingw32, for other ones (mingw32ce,
> > mingw32-prexp or mingw32-foobar or whatever), no define is added. The
> > follow-up, 0002 checks for getaddrinfo in ws2tcpip.h, which succeeds
> > or fails depending on the target-os selection.
> If others insist on this, it _might_ have better usability to just add
> the define and enable it when --enable-ipv6 is explicitly specified or something
> like that...
Yes, that would ease the configure usability and make it more
straightforward. However, the --enable-ipv6 option may be going away,
since getaddrinfo always is available in one form or another nowadays, so
the ipv6 specific codepath in udp.c will hopefully be the only one, soon.
(See the "Clean up ipv6 vs the udp protocol" thread from earlier this
week, in particular
But if others are ok with the GetProcAddress version, this doesn't really
More information about the ffmpeg-devel