[FFmpeg-devel] [PATCH] Factorize swscale.c:yuv2yuvX16inC()

Måns Rullgård mans
Sat Jan 16 18:09:16 CET 2010


Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Saturday 2010-01-16 17:07:55 +0100, Michael Niedermayer encoded:
>> On Sat, Jan 16, 2010 at 03:13:57PM +0100, Stefano Sabatini wrote:
>> > Hi, as in subject.
>> > -- 
>> > FFmpeg = Faithful and Forgiving Mastering Patchable Enlightening Game
>> 
>> >  swscale.c |   10 +---------
>> >  1 file changed, 1 insertion(+), 9 deletions(-)
>> > 67d627313437159361723b70704958fbecaf13c0  lsws-factorize-yuv2yuvx16inc.patch
>> 
>> rejected, patch just breaks optimizations no improvment
>
> Mmh, could someone explain why:
>
> if (1_OR_O_MACRO(x))
>    f(x, 1);
> else
>    f(x, 0);
>
> should be more efficient than:
> f(x, 1_OR_0_MACRO(x));
> ?

It might behave differently with constant propagation through inlining.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list