[FFmpeg-devel] [PATCH][RFC] add a list of generic tag names

Baptiste Coudurier baptiste.coudurier
Sun Jan 17 21:17:24 CET 2010


On 1/16/10 3:52 AM, Anton Khirnov wrote:
> On Fri, Jan 15, 2010 at 01:18:43AM -0800, Baptiste Coudurier wrote:
>>
>> album_artist
>>
> done
>>
>> Humm, I'm not sure about the description of artist.
>> Artist is used for the singer usually, and it's not necessarly the
>> "author" in the sense that he didn't write the song. It's not that
>> easy though I admit.
>>
> s/author/creator
>>
>> encoded_by
>>
> done
>>
>> This looks like "year" to me. 4 digits. like TYER in id3v2
>> This applies everywhere were the 4 digits are used.
>> The most common practice is to put only year, like in all my mp3/m4a
>> collection.
>>
> I don't really see a point in defining a separate 'year' tag, just using
> first 4 bytes of 'date' should be enough (at least for next 8k years ;))

Well, ok. Some code should be added to merge TDAT and TYER together for 
id3 < 2.4 though.

>> Finally :)
>> encoded_by also
>>
> done
>>
>> album_artist.
>>
> done
>>
>> '_' for all 3, to be consistent.
>>
> this case is different from album_artist (tag name+modifier vs. just tag name
> made of two words), so we shouldn't try to be consistent with it. also
> we already use dash for language.

IMHO It is a 2 words tag name, it should use the word separator which is 
'_'. Language has special suffix treatment, '-' is appended and removed 
like in some muxers. IMHO safer to use '_'

Patch is ok for me otherwise.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org



More information about the ffmpeg-devel mailing list