[FFmpeg-devel] [PATCH] Remove swscale_internal.h:fmt_depth()

Ramiro Polla ramiro.polla
Mon Jan 18 00:31:33 CET 2010


On Sun, Jan 17, 2010 at 9:25 PM, Stefano Sabatini
<stefano.sabatini-lala at poste.it> wrote:
> On date Monday 2010-01-18 00:11:03 +0100, Michael Niedermayer encoded:
>> On Sun, Jan 17, 2010 at 11:36:26PM +0100, Stefano Sabatini wrote:
>> > On date Sunday 2010-01-17 22:04:47 +0100, Michael Niedermayer encoded:
> [...]
>> > > if(regression == swscale_example) patch ok
>> > > else not ok
>> >
>> > I had to hack swscale-example since the recent change in pixfmt.h
>> > broke it (BTW does it ever worked with big-endian system?), anyway
>>
>> i suspect yes
>> but people are always eager to fix bugs at the wrong place and its so
>> easy to flip a rgb<->bgr that i cannot test
>>
>>
>> > what should I test with swscale-example?
>>
>> everything you plan to commit to swscale:)
>
> I mean what should I expect to find wrong in the swscale-example
> output if my patch would have broken something?

There should be no difference before and after the patch. The only
ones still causing issues are flags=1 (all fast_bilinear) and that one
we're talking about right now. If you add some new code, you should
make sure the SSD is low. In this particular case it should be 0 but
it's incredibly high. Take a look at the resulting image and you'll
see...



More information about the ffmpeg-devel mailing list