[FFmpeg-devel] [PATCH] broken build with --disable-optimizations

Michael Niedermayer michaelni
Mon Jan 18 17:44:04 CET 2010


On Mon, Jan 18, 2010 at 04:19:52PM +0000, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Mon, Jan 18, 2010 at 03:14:30PM +0000, M?ns Rullg?rd wrote:
> >> Michael Niedermayer <michaelni at gmx.at> writes:
> >> 
> >> > On Mon, Jan 18, 2010 at 02:01:11PM +0000, M?ns Rullg?rd wrote:
> >> >> Jai Menon <jmenon86 at gmail.com> writes:
> >> >> 
> >> >> > On Sun, Jan 17, 2010 at 10:06:17PM +0100, Michael Niedermayer wrote:
> >> >> >> On Mon, Jan 18, 2010 at 01:11:40AM +0530, Jai Menon wrote:
> >> >> >> > Hi,
> >> >> >> > 
> >> >> >> > Attached patch fixes it. This probably isn't correct and is
> >> >> >> > just meant to be an indicator of what the issue is.
> >> >> >> 
> >> >> >> Could you show me the error message with which it fails?
> >> >> >
> >> >> > here you go :
> >> >> >
> >> >> > /home/jai/ffbuild/libavcodec/libavcodec.a(h264.o): In function
> >> >> > `decode_significance_8x8_x86':
> >> >> > /home/jai/ffmpeg/libavcodec/x86/h264_i386.h:97: undefined reference to
> >> >> > `last_coeff_flag_offset_8x8'
> >> >> 
> >> >> The problem is all those non-inline functions in h264*.h. 
> >> >
> >> >> There is absolutely no sense whatsoever in having a non-inline
> >> >> function in a header file.
> >> >
> >> > There is a sense, some things like CABAC are constants that way but
> >> > would not if its in a C file. inlining OTOH may or may not be good,
> >> > its independant
> >> 
> >> I see your point.  However, you could still put both versions of the
> >> function in a .c file, perhaps by #including a template.h with
> >> different definitions.
> >
> > yes, but simply adding a dummy symbol for the 2 problematic tables seems
> > like the simpler solution. If we need a workaround until someone benchmarks
> > the stuff and checks what is best
> 
> Do the functions currently get inlined?

(functions from h264.h) some yes, some no

decode_significance* seem inlined here

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100118/276334a5/attachment.pgp>



More information about the ffmpeg-devel mailing list