[FFmpeg-devel] pixfmt.h installed header using HAVE_BIGENDIAN?

Stefano Sabatini stefano.sabatini-lala
Tue Jan 19 00:58:55 CET 2010


On date Monday 2010-01-18 23:15:39 +0000, M?ns Rullg?rd encoded:
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> 
> > On date Sunday 2010-01-17 19:09:19 +0100, Stefano Sabatini encoded:
> >> On date Sunday 2010-01-17 18:49:33 +0100, Michael Niedermayer encoded:
> >> > On Sun, Jan 17, 2010 at 04:52:12PM +0100, Stefano Sabatini wrote:
> >> [...]
> >> > > This is the simplest of the many variants we may adopt, others:
> >> > > * create a pixfmt_internal.h included automatically in
> >> > >   libavutil/internal.h
> >> > > * make each file to explicitely include the pixfmt_internal.h header
> >> > >   when required.
> >> > > 
> >> > > I saw mans' RFC after writing the patch, so another option could be to
> >> > > *sanely* expose the _NE stuff.
> >> > > 
> >> > > Regards.
> >> > > -- 
> >> > > FFmpeg = Foolish and Fiendish Multimedia Powered Evangelical Gadget
> >> > 
> >> > >  internal.h |   22 ++++++++++++++++++++++
> >> > >  pixfmt.h   |   25 -------------------------
> >> > >  2 files changed, 22 insertions(+), 25 deletions(-)
> >> > > f632d952c51d36f801e49e834c28550bc0fe6f00  fix-pixfmt-ne-stuff.patch
> >> > 
> >> > iam not in favor of this patch
> >> > its semantically wrong, as that stuff are pixel formats and it would force
> >> > us to include libavutil/internal.h from many places. And whatever you say
> >> > people will include libavutil/internal.h if half of the API they want to
> >> > use is there
> >> 
> >> So what about this variant:
> >> * create a pixfmt_internal.h and make each file to explicitely include
> >>   the pixfmt_internal.h header when required
> >> ?
> >
> > Like in attached, it also fixes swscale-example compilation.
> 
> I'm working on a proper fix with a public config header.  This is not
> needed.

Cool, patch dropped then.

Regards.
-- 
FFmpeg = Fostering Friendly Mega Pitiless Entertaining Gorilla



More information about the ffmpeg-devel mailing list