[FFmpeg-devel] [PATCH] WMA Voice decoder

Måns Rullgård mans
Wed Jan 20 18:55:59 CET 2010

"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> Hi,
> my first decoder, please be kind. :-).

Some general observations I forgot to include in the previous mail...

1. Use of double-precision FP
   Is this really necessary in all places?  Even if the answer is that
   some existing function takes double arguments, it should be checked
   whether a float version of same would be good enough here.

2. FP conversions
   You seem to be doing a lot of int to float conversions.  These take
   time, and it might be better to store some tables as floats
   instead, at least some of the small ones.  Type punning is often
   useful too.

3. memcpy, memset etc
   I noticed a number of calls to memcpy and memset.  Are all of these
   really needed?  Perhaps some could be done by pointer swapping

4. Coding style
   Good style overall.  ;-)

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list