[FFmpeg-devel] [PATCH] Make DECLARE_ALIGNED macros take array specifiers as separate argument
Thu Jan 21 00:04:29 CET 2010
On Wed, 2010-01-20 at 22:54 +0000, M?ns Rullg?rd wrote:
> Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
> > On Wed, 2010-01-20 at 22:25 +0000, M?ns Rullg?rd wrote:
> >> Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
> >> > In this case it could be fixed by moving at least one required argument
> >> > into the variable part, as in
> >> > #define DECLARE_ALIGNED_16(t, ...) DECLARE_ALIGNED(16, t, __VA_ARGS__)
> >> > or
> >> > #define DECLARE_ALIGNED_16(...) DECLARE_ALIGNED(16, __VA_ARGS__)
> >> That would defeat the intent of this patch, but I have another
> >> suggestion.
> > What do you mean? Wasn't the intent to allow adding an optional extra
> > argument (or arguments)? That should still work?
> The intent was to use the 'v' argument in the expansion for a specific
> compiler. That requires said argument to have a name.
Would that not be done through DECLARE_ALIGNED? The argument should
still have a name in the DECLARE_ALIGNED macro even if the redirection
through DECLARE_ALIGNED_16 doesn't name it.
More information about the ffmpeg-devel