[FFmpeg-devel] [PATCH] WMA Voice decoder

Michael Niedermayer michaelni
Thu Jan 21 14:13:11 CET 2010


On Thu, Jan 21, 2010 at 02:06:10PM +0100, Michael Niedermayer wrote:
> On Thu, Jan 21, 2010 at 12:16:40PM +0000, M?ns Rullg?rd wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > 
> > > On Thu, Jan 21, 2010 at 11:43:00AM +0000, M?ns Rullg?rd wrote:
> > >> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> > >> 
> > >> > On date Wednesday 2010-01-20 16:56:25 -0500, Ronald S. Bultje encoded:
> > >> > [...]
> > >> >> +/**
> > >> >> + * Initialize decoder.
> > >> >> + */
> > >> > [...]
> > >> >
> > >> > Just a note on the doxy, please use third person,
> > >> 
> > >> Please don't.  It looks weird to me, and I've never seen any other
> > >
> > > so does you pink bike look to me ;)
> > >
> > >> documentation do it.  It's time we stopped this madness.
> > >
> > > java*
> > 
> > FFmpeg is not written in java.
> 
> thats a straw man argument :)
> 
> "I've never seen any other documentation do it"
> "java"
> "FFmpeg is not written in java"
> 
> we could continue this along the lines of
> "But ffmpeg is written C"
> "C is a progamming language"
> ...
> 
> this misses the original point though that you tried to argue 3rd person
> was uncommon and you had not seen it, i do think its quite common and
> actually standard in some areas like javadocs which syntax we use as well

That said, i do think the worst is to waste time to change easy
understandable comments to a different grammer style and i think we
dont really disagree on this?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100121/aa2be701/attachment.pgp>



More information about the ffmpeg-devel mailing list