[FFmpeg-devel] [PATCH] WMA Voice decoder

Uoti Urpala uoti.urpala
Fri Jan 22 19:20:18 CET 2010


On Fri, 2010-01-22 at 10:48 -0500, Ronald S. Bultje wrote:
> >> >> +    int z = (uint16_t) (x * 49995 / y);

BTW I forgot to mention earlier than since x is signed int, x * 49995
can overflow here (undefined behavior). I assumed that it should be
unsigned. If the compiler creates a signed division the current code
should produce results different from that; have you tested it against
some kind of known correct results?




More information about the ffmpeg-devel mailing list