[FFmpeg-devel] [PATCH] RTP depacketizer for AMR

Luca Abeni lucabe72
Wed Jan 27 16:00:49 CET 2010


Martin Storsj? wrote:
> On Wed, 27 Jan 2010, Luca Abeni wrote:
> 
>> The only thing that looks debatable is the fact that the payload parser
>> touches the timestamp. I believe the timestamp should only be modified
>> by rtpdec.c::rtp_parse_packet() (in other word, the first frame of the
>> RTP packet is assigned the RTP timestamp, the other frames get
>> AV_NOPTS_VALUE). I think libavformat can correctly fill the missing
>> timestamps... Can you try it and see what happens?
> 
> It seems to me that the missing timestamps aren't filled in automatically 
> by libavformat. Around lines 421-424 in rtpdec.c, the timestamp is set to 
> 0

Congratulations, I think you just found a bug ;-)
That should be AV_NOPTS_VALUE, not 0.
Can you try this change and see what happens if the payload handler does
not mess with timestamps?


			Thanks,
				Luca



More information about the ffmpeg-devel mailing list