[FFmpeg-devel] [PATCH] Don't fail on Matroska with too many streams

Jai Menon jmenon86
Wed Jan 27 19:19:17 CET 2010


On Wed, Jan 27, 2010 at 11:27 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Jan 27, 2010 at 11:00:01PM +0530, Jai Menon wrote:
>> On Wed, Jan 27, 2010 at 10:53 PM, Joakim Plate <elupus at ecce.se> wrote:
>> >> >
>> >> > iam not matroska maintainer but i take the liberty to reject this
>> >> > please work on dynamic allocation of things so that the MAX_STREAMS
>> >> > limit disappears or advocate bumping the value up with the next
>> >> > major ver bump.
>> >>
>> >> just curious : should the removal of MAX_FILES also be considered? i'm
>> >> not suggesting i have a use case for this though, just asking...
>> >>
>> >
>> > If so, please bump to atleast 41, since that is the maximum allowed for dvds
>> > and what we have it patched to in our code.
>>
>> well, i can submit a patch increasing the current limits right now
>> (with the required #ifs) but the long term plan is to dynamically
>> allocate per-stream/file contexts as needed. is just increasing both
>> these values okay for now, michael?
>
> yes, wit the needed ifdefs for MAX_STREAMS
> MAX_FILES is just in ffmpeg.c and shouldnt need ifdefs

attached, with arbitrarily chosen value. should i increase/decrease it?

-- 
Jai Menon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: max_files_bump.patch
Type: text/x-patch
Size: 322 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100127/72ac6407/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: max_streams_bump.patch
Type: text/x-patch
Size: 370 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100127/72ac6407/attachment-0001.bin>



More information about the ffmpeg-devel mailing list