[FFmpeg-devel] [PATCH] Don't fail on Matroska with too many streams

Jai Menon jmenon86
Wed Jan 27 20:15:49 CET 2010


On Thu, Jan 28, 2010 at 12:08 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Jan 27, 2010 at 11:49:17PM +0530, Jai Menon wrote:
>> On Wed, Jan 27, 2010 at 11:27 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Wed, Jan 27, 2010 at 11:00:01PM +0530, Jai Menon wrote:
>> >> On Wed, Jan 27, 2010 at 10:53 PM, Joakim Plate <elupus at ecce.se> wrote:
>> >> >> >
>> >> >> > iam not matroska maintainer but i take the liberty to reject this
>> >> >> > please work on dynamic allocation of things so that the MAX_STREAMS
>> >> >> > limit disappears or advocate bumping the value up with the next
>> >> >> > major ver bump.
>> >> >>
>> >> >> just curious : should the removal of MAX_FILES also be considered? i'm
>> >> >> not suggesting i have a use case for this though, just asking...
>> >> >>
>> >> >
>> >> > If so, please bump to atleast 41, since that is the maximum allowed for dvds
>> >> > and what we have it patched to in our code.
>> >>
>> >> well, i can submit a patch increasing the current limits right now
>> >> (with the required #ifs) but the long term plan is to dynamically
>> >> allocate per-stream/file contexts as needed. is just increasing both
>> >> these values okay for now, michael?
>> >
>> > yes, wit the needed ifdefs for MAX_STREAMS
>> > MAX_FILES is just in ffmpeg.c and shouldnt need ifdefs
>>
>> attached, with arbitrarily chosen value. should i increase/decrease it?
>>
>> --
>> Jai Menon
>
>> ?ffmpeg.c | ? ?2 +-
>> ?1 file changed, 1 insertion(+), 1 deletion(-)
>> 746952682fe39a3112a5470ab5afe061eda5102c ?max_files_bump.patch
>
> ok

applied.

>> ?avformat.h | ? ?4 ++++
>> ?1 file changed, 4 insertions(+)
>> e6073e9da4c8ea87d3abcf32de6fa1f3056cdf7c ?max_streams_bump.patch
>
> ok

applied.

-- 
Jai Menon



More information about the ffmpeg-devel mailing list