[FFmpeg-devel] [PATCH] RTP depacketizer for AMR

[Martin Storsjö]

On Wed, 27 Jan 2010, Luca Abeni wrote:

> > I think the best thing here is to return whole packets since the
> > decoder handles that anyway.
> 
> If this (returning all the frames at the same time) works, I agree. After all,
> this is what the AAC payload parser is doing (I remember people complaining
> about this behaviour, but I do not know if there was a real problem and if/how
> it was fixed).

I think the AAC case is handled by a parser.

> > RTP depacketizers should not mess with timestamps, it's the wrong
> > place.
> 
> I agree ;-)
> But let's see if and how the AMR decoder can cope with the data produced by
> this demuxer if the payload handler does not set the timestamps.

If rtpdec.c sets pts to AV_NOPTS_VALUE, the correct pts is set by some 
other code, so that method does seem to work, we only need some kind of 
fix for rtpdec.c, so that it actually sets this value in these cases.

// Martin