[FFmpeg-devel] [PATCH] remove ap->[audio|video]_codec_id usage from lavf

Jai Menon jmenon86
Thu Jan 28 16:54:16 CET 2010


On Thu, Jan 28, 2010 at 5:27 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Jan 28, 2010 at 03:18:06PM +0530, Jai Menon wrote:
>> On Thu, Jan 28, 2010 at 11:51 AM, Jai Menon <jmenon86 at gmail.com> wrote:
>> > Hi,
>> >
>> > Since AVFormatParameters::[audio|video]_codec_id are slated for
>> > removal at next major bump, maybe we could stop using them. regression
>> > tests pass.
>>
>> Here are the changes to ffmpeg.c as well.
>
>> About the
>> pgmyuv_compatibility hack, does that even work currently? i think it
>> would still error out when no -vcodec opt is passed, which seems to be
>> the case when -fmt pgmyuv is used. maybe the codec_id lookup can be
>> avoided if fmt is pgmyuv...
>
> i think you have to move that below ?the code that sets ic->video_codec_id

Yeah, i guess i was reading the wrong diff.
patch attached.

-- 
Jai Menon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove_ap_codec_id_ffmpeg.c.patch
Type: text/x-patch
Size: 1071 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100128/0d680097/attachment.bin>



More information about the ffmpeg-devel mailing list