[FFmpeg-devel] [PATCH] remove ap->[audio|video]_codec_id usage from lavf

Jai Menon jmenon86
Thu Jan 28 17:22:48 CET 2010


On Thu, Jan 28, 2010 at 9:25 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Jan 28, 2010 at 09:24:16PM +0530, Jai Menon wrote:
>> On Thu, Jan 28, 2010 at 5:27 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Thu, Jan 28, 2010 at 03:18:06PM +0530, Jai Menon wrote:
>> >> On Thu, Jan 28, 2010 at 11:51 AM, Jai Menon <jmenon86 at gmail.com> wrote:
>> >> > Hi,
>> >> >
>> >> > Since AVFormatParameters::[audio|video]_codec_id are slated for
>> >> > removal at next major bump, maybe we could stop using them. regression
>> >> > tests pass.
>> >>
>> >> Here are the changes to ffmpeg.c as well.
>> >
>> >> About the
>> >> pgmyuv_compatibility hack, does that even work currently? i think it
>> >> would still error out when no -vcodec opt is passed, which seems to be
>> >> the case when -fmt pgmyuv is used. maybe the codec_id lookup can be
>> >> avoided if fmt is pgmyuv...
>> >
>> > i think you have to move that below ?the code that sets ic->video_codec_id
>>
>> Yeah, i guess i was reading the wrong diff.
>> patch attached.
>>
>> --
>> Jai Menon
>
>> ?ffmpeg.c | ? ?7 +++----
>> ?1 file changed, 3 insertions(+), 4 deletions(-)
>> 43d1189ddae47ebfcd671828d61f86a813d95a57 ?remove_ap_codec_id_ffmpeg.c.patch
>
> ok

thanks, applied.

-- 
Jai Menon



More information about the ffmpeg-devel mailing list