[FFmpeg-devel] [PATCH] allow non-repeating pulse vectors in ff_set_fixed_vector()

Ronald S. Bultje rsbultje
Fri Jan 29 01:12:16 CET 2010


Hi,

On Jan 28, 2010, at 6:53 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
> On Thu, Jan 28, 2010 at 9:39 AM, Ronald S. Bultje  
> <rsbultje at gmail.com> wrote:
>>
>> $subj, used in WMAVoice and adapted from a previous patch by Mans'
>> suggestions on how to make optimal code with gcc. The nice thing is
>> that the default behaviour (repeat) can be done in a one-liner for  
>> all
>> items in the array, whereas complex behaviour (like WMAVoice,
>> no-repeat) can be done in ways that punishes that decoder alone, not
>> others. (hence the "no-repeat" instead of "repeat").
>
> Missing changes in siprdec.c (passing AMRFixed.no_repeat_mask
> uninitialized is a bad idea).
> Besides that, ok if tested not to break SIPR.

But it doesn't actually use it, do you still want me to set it?

Ronald



More information about the ffmpeg-devel mailing list