[FFmpeg-devel] [PATCH] forbid strcpy
Sat Jan 30 18:59:41 CET 2010
On Sat, Jan 30, 2010 at 11:02:34AM -0500, Ronald S. Bultje wrote:
> On Jan 30, 2010, at 10:34 AM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> >this will cause a lot of build failures, so can't be applied as
> >is, but
> >please all maintainers: either remove any strcpy uses from your
> >copy or
> >complain now, or I take the freedom to modify your code without
> This is not ok, strcpy() is fine and faster in a lot of places where
> we copy between internal buffers. There is nothing wrong with that.
Please show me a single use where we'd notice if it was 20 times faster.
I find it unlikely that there are cases where speed matters and
strcpy would be acceptable, it certainly is not particularly fast.
More information about the ffmpeg-devel