[FFmpeg-devel] [PATCH] Extend show_pix_fmts() to make it print the input/output support

Michael Niedermayer michaelni
Sun Jan 31 02:57:48 CET 2010


On Sun, Jan 31, 2010 at 02:38:43AM +0100, Stefano Sabatini wrote:
> On date Sunday 2010-01-31 01:20:55 +0100, Michael Niedermayer encoded:
> > On Sat, Jan 30, 2010 at 09:54:48PM +0100, Stefano Sabatini wrote:
> [...]
> > > ------------------------------------------------------------------------
> > > r19993 | lucabe | 2006-09-27 13:41:36 +0200 (Wed, 27 Sep 2006) | 2 lines
> > > 
> > > Add support for YUVJ formats
> > > ------------------------------------------------------------------------
> > > 
> > > but then if you look at the diff there is no addition to the
> > > sws_isSupported{In,Out} macros.
> > 
> > exact, thats how it was intended
> > adding them there at least feels odd to me. They are not true pixel formats
> > but hacks specific to jpeg in libavcodec. They are deprected and should be
> > removed (that is from libavcodec first and swscale second)
> > adding them to more places is not pretty ...
> > but they must be tested by swscale-test, that said iam not against your
> > patch i just dont feel its pretty
> 
> Another variant which doesn't require to declare yuvj* support, and
> still makes it possible to test them with my swscale-test-all.sh
> script.

add them to the macro as you originally intended

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100131/59ef96cf/attachment.pgp>



More information about the ffmpeg-devel mailing list