[FFmpeg-devel] [PATCH] WMA Voice decoder

Vitor Sessak vitor1001
Sun Jan 31 03:51:38 CET 2010


Michael Niedermayer wrote:
> On Sun, Jan 31, 2010 at 01:29:47AM +0000, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>>
>>> On Sat, Jan 30, 2010 at 05:03:26PM -0500, Ronald S. Bultje wrote:
>>>> Hi Vitor,
>>>>
>>>> On Sat, Jan 23, 2010 at 12:06 AM, Vitor Sessak <vitor1001 at gmail.com> wrote:
>>>>> Ronald S. Bultje wrote:
>>>>>> +static int get_vbm_bits(GetBitContext *gb)
>>>> [..]
>>>>> I've never actually used the {init,get}_vlc() functions, so I'm not sure,
>>>>> but it looks like they could be useful here.
>>>> I think that does something else, and has a max_depth==3 (this one has
>>>> 6), or did I misread that? Michael?
>>> Not enough context quoted to awnser question
>> We've solved it on IRC.  You should have the logs by now.
> 
> yes, can you also make a bot that posts me a few hours more time to
> read it :)
> 
> anyway, about this code and what my tired mined managed to extract from th log
> about it, it does not look speed critical to me so i doubt
> it would be faster with get_vlc*

It doesn't look speed critical to me neither, but I hoped that not 
reinventing get_vlc() would make the code cleaner. If it doesn't, indeed 
there is no point in changing the existing code.

-Vitor



More information about the ffmpeg-devel mailing list