[FFmpeg-devel] [PATCH] RTSP muxer, round 3

Martin Storsjö martin
Sun Jan 31 12:59:53 CET 2010


Hi,

On Sat, 30 Jan 2010, Ronald S. Bultje wrote:

> On Fri, Jan 22, 2010 at 3:17 AM, Martin Storsj? <martin at martin.st> wrote:
> > On Wed, 20 Jan 2010, Ronald S. Bultje wrote:
> >> (Will look at the rest in a bit.)
> >
> > Here's an updated series, to work with the latest SVN. 0001 is updated to
> > fit with the updated parameter signature to rtsp_send_cmd_async, and 0010
> > is updated to use the _async version for sending the commands in
> > rtsp_write_close (as you did for rtsp_read_close), the rest is unmodified.
> 
> General comments:
> - should we split this in 3 files (rtsp, rtspdec, rtspenc.c) for
> easier maintenance?

That might be a good idea. Would it be ok to defer that to after getting 
this applied?

> - the priv_data is not the same for demuxer and muxer, should we
> document that? Did you double check all possible cases that this is
> handled OK?

Documented it. Double checked - transport_priv is used only in the 
setup/close routines, where is_output is checked, or in read/write 
functions (rtsp_fetch_packet, rtsp_write_packet), where only either one of 
the alternatives is applicable.

Updated patch series attached. Except for rebasing it onto the latest 
version and adding the documentation mentioned above, I check the lower 
transport mask in 0009, since only UDP output is supported at the moment.

// Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-internal-rtsp-functions-for-doing-requests-that-.patch
Type: text/x-diff
Size: 2792 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100131/57eb04a0/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-a-RTSPClientState-for-recording.patch
Type: text/x-diff
Size: 855 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100131/57eb04a0/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-a-flag-for-storing-the-direction-of-the-rtsp-ses.patch
Type: text/x-diff
Size: 813 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100131/57eb04a0/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Create-AVFormatContext-objects-as-private-transport-.patch
Type: text/x-diff
Size: 4189 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100131/57eb04a0/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Add-proper-mode-to-output-setup-requests.patch
Type: text/x-diff
Size: 1165 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100131/57eb04a0/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Split-out-the-input-specific-part-of-rtsp_read_heade.patch
Type: text/x-diff
Size: 3621 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100131/57eb04a0/attachment-0005.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Split-rtsp_read_header-into-a-reusable-function-rtsp.patch
Type: text/x-diff
Size: 2038 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100131/57eb04a0/attachment-0006.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Add-a-function-rtsp_setup_output_streams-for-announc.patch
Type: text/x-diff
Size: 2353 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100131/57eb04a0/attachment-0007.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Enable-rtsp_connect-to-work-for-output-too.patch
Type: text/x-diff
Size: 1851 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100131/57eb04a0/attachment-0008.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Add-an-RTSP-muxer.patch
Type: text/x-diff
Size: 7237 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100131/57eb04a0/attachment-0009.patch>



More information about the ffmpeg-devel mailing list